Title: README: correct link to CONTRIBUTING.md
Currently Kallithea renders the link relative to /, giving "https://k.copyleft.org/CONTRIBUTING.md";. This is offputting to potential contributors. There are other relative links in CONTRIBUTING.md, but that file is not rendered in the web interface anyway.
Under review
There are no reviewers
git pull https://k.copyleft.org/guide-hdhoang master
2017-04-27 01:03:55
Hieu Hg (hdhoang)
i@hdhoang.space
Git pull requests don't support updates yet.
Pull Request Reviewers
Potential Reviewers
Click to add the repository owner as reviewer:
2 comments (0 inline, 2 general)
Showing 1 commit
1 2017-04-27 04:57:39
hdhoang
74d01906e0a1 master
README: correct link to CONTRIBUTING.md Currently Kallithea renders the link relative to /, giving "https://k.copyleft.org/CONTRIBUTING.md";. This is offputting to potential contributors. There are other relative links in CONTRIBUTING.md, but that file is not rendered in the web interface anyway.
Common ancestor: 85bbbf1ec649
1 file changed with 1 insertions and 1 deletions:
↑ Collapse Diff ↑
README.md | master master
...
 
@@ -26,13 +26,13 @@ Note the
26 26
 
Typically, copies of this repository on  sites other than copyleft.org are for informational and backup
27 27
 
purposes only.
28 28
 

	
29 29
 
## Contributing
30 30
 

	
31 31
 
Improvements of all kinds and manner are welcome.  Please review
32
 
[the instructions and details regarding making contributions](CONTRIBUTING.md)
32
 
[the instructions and details regarding making contributions](https://k.copyleft.org/guide/files/tip/CONTRIBUTING.md)
33 33
 
for more information.
34 34
 

	
35 35
 
Copyleft.org may be sponsored by various organizations, and organizations may
36 36
 
also republish some, or all, of the output of this project under the terms of
37 37
 
the CC BY-SA license.  However, contributors' work is their own, and thus the
38 38
 
opinions expressed in their contributions, IRC utterances, commit messages,
Hieu Hg (hdhoang)
6 months and 23 days ago on pull request "README: correct link to CONTRIBUTING.md"

Status change: Under review

bill auger (bill-auger)
5 months and 24 days ago on pull request "README: correct link to CONTRIBUTING.md"
im not sure what is the objection to this - relative URL ensures that the links are portable for mirrors - for example if the repo (and README.md) is hosted on github or notabug then the link to COMTRIBUTING.md should be to the same site and not back to the kalithea instance - this ensure everything still works locally in the case that the main site is down and when others publish copies as they are encouraged to do
2 comments (0 inline, 2 general)